Replace escape_quotes with json.dumps in DOM.create_element
#1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`escape_quotes` is inadequate here, as it will happily leave multiline strings as they are, which is a syntax error in javascript. it also doesn't seem to adequately deal with things like existing backslash escapes in the string. `json.dumps` is guaranteed to produce valid json, which is also guaranteed to be a valid javascript data structure. by ensuring the type of `html` to be `str`, we guarantee that the output of `json.dumps` will be a valid javascript string, properly quoted and escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
escape_quotesis inadequate here, as it will happily leave multiline strings as they are, which is a syntax error in javascript. It also doesn't seem to adequately deal with things like existing backslash escapes in the string.json.dumpsis guaranteed to produce valid json, which is also guaranteed to be a valid javascript data structure. By ensuring the type ofhtmlto bestr, we guarantee that the output ofjson.dumpswill be a valid javascript string, properly quoted and escaped.