Removing one task per call layer on control plane. #5012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are useless. The control plane is already an actor.
fulmicoton
force-pushed
the
remove-non-sense-on-task-per-call
branch
from
913cc15
to
d5a5659
Compare
guilload
reviewed
May 31, 2024
| .stack_delete_source_layer(OneTaskPerCallLayer) | ||
| .stack_get_or_create_open_shards_layer(OneTaskPerCallLayer) | ||
| .stack_layer(CP_GRPC_SERVER_METRICS_LAYER.clone()) | ||
| .stack_layer(LoadShedLayer::new(100)) |
There was a problem hiding this comment.
Now that we have optimized a bunch of metastore queries, I wonder whether we should bump up that value. Thoughts?
There was a problem hiding this comment.
The load shedder? I think 100 is plenty for the control plane.
There was a problem hiding this comment.
Maybe not at midnight UTC when 3000+ new shards need to be opened.
guilload
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are useless. The control plane is already an actor.