-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tbb 240411 #2377
Tbb 240411 #2377
Conversation
Thanks @rsbivand. But: This works except when tbb is not present, in which case on macOS, it errors for me. During build:
|
Also, in configure.ac, should this not prevent the dSYM detritus?
|
Please report all of the install output, or run from the command line |
(base) KB-MacBook-Pro-14:quanteda kbenoit$ brew uninstall tbb
Uninstalling /opt/homebrew/Cellar/tbb/2021.12.0... (177 files, 2.7MB)
However, when I try to build it in RStudio, I get this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rsbivand
#2372 fixed test for tbb;
checklist
1 OK,
2 agree with comment, only macOS has dSYMs, but there is detritus.
3 compile and link tested, and execution of minimal program tested if compiling and linking succeeds
4 added --enable-tbb=no or equivalently --disable-tbb, and run pkg-config and all subsequent tests conditional on the user not disabling TBB; by default enabled,
5 see comments in that commit.