Skip to content

Commit

Permalink
Update for resubmission of v4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Kenneth Benoit authored and Kenneth Benoit committed Apr 4, 2024
1 parent 053ba50 commit 63983a2
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@

Fixed:

- Breaking documentation link in two .Rd files in the package **tosca** is now fixed on the **quanteda** side.
- Breaking documentation link in two .Rd files in the package **tosca**: fixed on the **quanteda** side.

- **tidytext** - We have not only informed the package maintainer that their use in a vignette of a function deprecated in v3 (released in 2021) is now defunct, but also we issued a PR to fix this (https://github.com/juliasilge/tidytext/pull/242).
- **RNewsflow** - Fised on CRAN, based on our PR (https://github.com/kasperwelbers/RNewsflow/pull/9).

- **RNewsflow** - We have not only informed the package maintainer that their use in a vignette of a function deprecated in v3 (released in 2021) is now defunct, but also we issued a PR to fix this (https://github.com/kasperwelbers/RNewsflow/pull/9).
Informed and pending a fix:

Not fixed:

- This breaks the **gofastr** package because that package calls functions that we first deprecated in version 3.3 and have now made defunct. We issued a pull request fixing this for that package nearly six months ago (https://github.com/trinker/gofastr/pull/12) and the package maintainer has yet to accept it.
- **tidytext**: We have not only informed the package maintainer that their use in a vignette of a function deprecated in v3 (released in 2021) is now defunct, but also we issued a PR to fix this (https://github.com/juliasilge/tidytext/pull/242).

- **gofastr**: That package calls functions that we first deprecated in version 3.3 and have now made defunct. We issued a pull request fixing this for that package nearly six months ago (https://github.com/trinker/gofastr/pull/12) and the package maintainer has yet to accept it.


# Submission notes
Expand All @@ -31,8 +30,8 @@ Major changes include:

## Test environments

* local macOS 14.2.1, R 4.3.2
* Ubuntu 22.04 LTS, R 4.3.2
* local macOS 14.2.1, R 4.3.3
* Ubuntu 22.04 LTS, R 4.3.3
* Windows release via devtools::check_win_release()
* Windows devel via devtools::check_win_devel()
* Windows oldrelease via devtools::check_win_oldrelease()
Expand All @@ -43,4 +42,4 @@ All checks are clean, locally and on GitHub's CI for multiple platforms.

## Reverse dependency and other package conflicts

None, except those noted above.
None, except those noted above.

0 comments on commit 63983a2

Please sign in to comment.