Rescore universal query #4252
Merged
Rescore universal query #4252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coszio
reviewed
May 17, 2024
coszio
reviewed
May 17, 2024
agourlay
force-pushed
the
universal-query-rescoring
branch
from
753caea
to
2e699c8
Compare
|
@coszio I have pushed a change to keep intermediate results in case of top level RRF rescoring. I applied the merging properly at the lower level by tracking the depth of the recursion. WDYT? |
coszio
approved these changes
May 21, 2024
| // in case of top level RFF we need to propagate intermediate results | ||
| // so the number of results is not limited by the outer limit at the shard level | ||
| // the first source returned all its inner results | ||
| assert_eq!(sources_scores[0].len(), inner_limit); |
| } | ||
|
|
||
| self.merge_prefetches(sources, &prefetch.merge).await | ||
| if depth == 0 && prefetch.merge.rescore == Some(ScoringQuery::Fusion(Fusion::Rrf)) { |
There was a problem hiding this comment.
TBH I thought it was going to be handled at do_planned_query, but this way there is less repetition. I like this.
generall
pushed a commit
that referenced
this pull request
May 26, 2024
* Rescore universal query * fix tests * top level RRF fusion should not merge results at shard level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation for re-scoring with RRF or a query at the shard level.
I took extra care make this testable by setting up test fixtures for shard tests.