Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Semver type in version info response #4193

Closed
wants to merge 1 commit into from
Closed

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented May 7, 2024

schemars supports the semver type. Since we expose a semver I decided to explore the idea of using the respective type there.

As shown in the OpenAPI specification this constrains the allowed pattern to match the semver specification. Though not necessary, I think that's a valid addition.

Any objections or thoughts?

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

@timvisee timvisee requested review from agourlay and generall May 7, 2024 07:44
@timvisee timvisee changed the title Use Semver version type in version info response Use Semver type in version info response May 7, 2024
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me if the Python REST client is fine :)

@timvisee
Copy link
Member Author

timvisee commented May 7, 2024

Fine for me if the Python REST client is fine :)

Yeah, I'll give checking that a shot.

@timvisee
Copy link
Member Author

timvisee commented May 7, 2024

Fine for me if the Python REST client is fine :)

Generating the REST client and running integration tests works fine 👍

@generall
Copy link
Member

generall commented May 7, 2024

Any objections or thoughts?

no objections, but what problem does it solve?

@timvisee
Copy link
Member Author

timvisee commented May 8, 2024

no objections, but what problem does it solve?

None.

It just adds more type information. Since that is supported out of the box I figured; why not.

@timvisee
Copy link
Member Author

Closing this since I don't think we're enthusiastic enough about this change 😄

@timvisee timvisee closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants