-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated PointsUpdateOperation
variants
#3663
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure what effect removing these fields might have on our generated clients.
Tagging @generall for this opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coszio have you tried generating the clients with this PR?
I'd say Python Rust & Go.
I assume that this will break clients using the deprecated types at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python client was already using both fields (new and deprecated) at once, so removing one won't hurt as long as users weren't using the gRPC types directly.
For other clients like the Rust one which are dependent of only gRPC, this will be breaking, yes.
@generall do we want this change here, or only in client side? |
Only on client side for now |
Drafting then |
In Qdrant 1.7, we deprecated these fields.
For 1.8, we can safely remove them.Edit: We will remove these eventuallyRelated PR: qdrant/qdrant-client#502
All Submissions:
dev
branch. Did you create your branch fromdev
?Changes to Core Features: