Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated PointsUpdateOperation variants #3663

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

coszio
Copy link
Contributor

@coszio coszio commented Feb 21, 2024

In Qdrant 1.7, we deprecated these fields. For 1.8, we can safely remove them. Edit: We will remove these eventually

Related PR: qdrant/qdrant-client#502

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@coszio coszio requested a review from timvisee February 21, 2024 18:21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure what effect removing these fields might have on our generated clients.

Tagging @generall for this opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coszio have you tried generating the clients with this PR?
I'd say Python Rust & Go.

I assume that this will break clients using the deprecated types at least.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python client was already using both fields (new and deprecated) at once, so removing one won't hurt as long as users weren't using the gRPC types directly.

For other clients like the Rust one which are dependent of only gRPC, this will be breaking, yes.

@coszio
Copy link
Contributor Author

coszio commented Feb 28, 2024

@generall do we want this change here, or only in client side?

@generall
Copy link
Member

generall commented Mar 1, 2024

Only on client side for now

@coszio
Copy link
Contributor Author

coszio commented Mar 1, 2024

Drafting then

@coszio coszio marked this pull request as draft March 1, 2024 12:09
@coszio coszio added the chore Nice to have improvement label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Nice to have improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants