WebUI: Add "isPrivate" filter for 'info' API #20833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManiMatter
force-pushed
the
info-API-filter-by-isPrivate-flag
branch
3 times, most recently
from
31955e6
to
37ee324
Compare
ManiMatter
force-pushed
the
info-API-filter-by-isPrivate-flag
branch
from
37ee324
to
44e71b0
Compare
glassez
requested changes
May 16, 2024
glassez
reviewed
May 16, 2024
glassez
reviewed
May 16, 2024
glassez
reviewed
May 16, 2024
|
@glassez Thanks having included this on milestone 5.0, and for having reviewed the code. I was not able to figure out how to test whether the feature works properly. Just wanted to check if you had a chance to test if it actually works? Many thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is already possible to filter the "info" response by hashes, status, tag, category.
Since the "isPrivate" flag has been added in #20686, it would be nice if it was possible to also pre-filter the response by this attribute.
I have - to the best of my abilities - implemented the code, but it is at the edge of my skills and I would appreciate your review.
The failed checks seem macOS related and affecting any PRs right now, thus not triggered by the changes I propose here