-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sentinel-2 MSI L2A SAFE datasets #2783
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2783 +/- ##
==========================================
- Coverage 95.95% 95.95% -0.01%
==========================================
Files 379 366 -13
Lines 53888 53563 -325
==========================================
- Hits 51708 51394 -314
+ Misses 2180 2169 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 9262915667Details
💛 - Coveralls |
Thanks for adding this, it was on my to-do list but you got there first :-) |
🍺 |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@simonrp84 If you got time pls also take a look. :D |
Thanks a lot for this new reader functionality @yukaribbba ! |
Sure! |
The two YAMLs are separated now. |
@mraspaud Could you take some time to review this? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice that there is so little to change the msi reader python code! I have some questions inline.
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Add support for Sentinel-2 MSI L2A SAFE datasets
Composites family: