Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sentinel-2 MSI L2A SAFE datasets #2783

Open
wants to merge 52 commits into
base: main
Choose a base branch
from

Conversation

yukaribbba
Copy link
Contributor

@yukaribbba yukaribbba commented Apr 18, 2024

Add support for Sentinel-2 MSI L2A SAFE datasets

  • Tests added
  • Fully documented

Composites family:
image
image
image

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (3b9c04e) to head (d2e3c9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   95.95%   95.95%   -0.01%     
==========================================
  Files         379      366      -13     
  Lines       53888    53563     -325     
==========================================
- Hits        51708    51394     -314     
+ Misses       2180     2169      -11     
Flag Coverage Δ
behaviourtests 4.04% <0.00%> (-0.05%) ⬇️
unittests 96.04% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 9262915667

Details

  • 106 of 106 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 96.05%

Files with Coverage Reduction New Missed Lines %
satpy/readers/msi_safe.py 1 98.26%
Totals Coverage Status
Change from base Build 9157044280: 0.02%
Covered Lines: 51623
Relevant Lines: 53746

💛 - Coveralls

@simonrp84
Copy link
Member

Thanks for adding this, it was on my to-do list but you got there first :-)

@yukaribbba
Copy link
Contributor Author

Thanks for adding this, it was on my to-do list but you got there first :-)

🍺

@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba
Copy link
Contributor Author

@simonrp84 If you got time pls also take a look. :D

@mraspaud
Copy link
Member

Thanks a lot for this new reader functionality @yukaribbba !
One general comment before I dive deeper into this, could you make this a separate yaml file for this reader? The python code can stay with the l1 reader, but it will be easier to have a separate yaml file as this will make it effectively separate from the l1 reader for the user.

@yukaribbba
Copy link
Contributor Author

Sure!

@yukaribbba
Copy link
Contributor Author

The two YAMLs are separated now.

@yukaribbba
Copy link
Contributor Author

@mraspaud Could you take some time to review this?

@mraspaud
Copy link
Member

Yes

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that there is so little to change the msi reader python code! I have some questions inline.

satpy/dataset/dataid.py Outdated Show resolved Hide resolved
satpy/etc/composites/msi.yaml Outdated Show resolved Hide resolved
satpy/etc/composites/msi.yaml Outdated Show resolved Hide resolved
satpy/etc/composites/msi.yaml Outdated Show resolved Hide resolved
satpy/etc/readers/msi_safe_l2a.yaml Show resolved Hide resolved
@yukaribbba
Copy link
Contributor Author

pre-commit.ci autofix

@yukaribbba yukaribbba requested a review from mraspaud May 28, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants