add support of masking olci l1b products by using quality flags #2687
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2687 +/- ##
==========================================
+ Coverage 95.32% 95.35% +0.02%
==========================================
Files 371 371
Lines 52435 52440 +5
==========================================
+ Hits 49982 50002 +20
+ Misses 2453 2438 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7212041175Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
| """Init the file handler.""" | ||
| super().__init__(filename, filename_info, filetype_info, engine) | ||
| self.cal = cal.nc | ||
| if cal is not None: |
There was a problem hiding this comment.
In what conditions is cal None? Should this be required (but keep it as a kwarg for consistency) and raise an error if it is None?
There was a problem hiding this comment.
The cal will be None when loading mask into the scene. In that case, that is alright since we only care about the mask_items.
djhoese
added
enhancement
| mocked_dataset.return_value = xr.Dataset({"quality_flags": (["rows", "columns"], | ||
| np.array([1 << (x % 32) for x in range(35)]).reshape(5, 7))}, | ||
| coords={"rows": np.arange(5), | ||
| "columns": np.arange(7)}) | ||
| ds_id = make_dataid(name="mask") | ||
| filename_info = {"mission_id": "S3A", "dataset_name": "mask", "start_time": 0, "end_time": 0} | ||
| test = NCOLCI1B("somedir/somefile.nc", filename_info, "c") |
There was a problem hiding this comment.
Depending on how bored you are, you could change this to not using mocking but instead create a real file on disk. I realize you're just copying what was here before which is why I won't push it.
Thanks Dave. |
This PR added support of using the quality flags from the qualityFlags.nc file to mask the OCLI L1b products, similar as using wqsf file masking OLCI L2 products.