Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnMAP HSI L1B reader #2590

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add EnMAP HSI L1B reader #2590

wants to merge 13 commits into from

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Oct 6, 2023

  • Tests added
  • Fully documented

This PR supports reading the EnMAP L1B ZIP file provided by DLR. This reader relied on enpt to read variables from TIFF and METADATA files in the zip file.

@zxdawn zxdawn requested a review from simonrp84 October 6, 2023 15:26
@zxdawn zxdawn self-assigned this Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2590 (2f6b366) into main (95eb01a) will decrease coverage by 0.16%.
Report is 155 commits behind head on main.
The diff coverage is 11.22%.

❗ Current head 2f6b366 differs from pull request most recent head cd6cf1e. Consider uploading reports for the commit cd6cf1e to get more accurate results

@@            Coverage Diff             @@
##             main    #2590      +/-   ##
==========================================
- Coverage   94.91%   94.76%   -0.16%     
==========================================
  Files         351      353       +2     
  Lines       51215    51323     +108     
==========================================
+ Hits        48611    48635      +24     
- Misses       2604     2688      +84     
Flag Coverage Δ
behaviourtests 4.26% <0.00%> (-0.03%) ⬇️
unittests 95.38% <11.22%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
satpy/readers/hsi_l1b.py 11.22% <11.22%> (ø)

... and 15 files with indirect coverage changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6433889494

  • 11 of 98 (11.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 95.331%

Changes Missing Coverage Covered Lines Changed/Added Lines %
satpy/readers/hsi_l1b.py 11 98 11.22%
Totals Coverage Status
Change from base Build 6426189025: -0.2%
Covered Lines: 48758
Relevant Lines: 51146

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants