Disable PIP version check in collect_env #126390
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves downloading from PYPI and using the users $HOME
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126390
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8212462 with merge base d61a81a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
It is not required and doesn't exactly do what the name suggests
drisspg
added
the
triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids downloading from PYPI and using the users $HOME just for a check that isn't needed here.
Also a small refactoring to remove a nested function that isn't named ideally and the single-use code is small enough to be even better readable