Fix inplace lshift usage #126387
Open
Fix inplace lshift usage #126387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126387
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 67fba28 with merge base d61a81a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Skylion007
reviewed
May 16, 2024
|
Also sign the CLA |
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
|
@DominikaJedynak you need to sign the CLA for this to get merged. |
drisspg
added
the
triaged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that there is a typo: for the rhift op we distinguish between inplace and regular implementation but for the lshift we call lshift in both situations.