make torch.save(PrivateUse1's Tensor) more generalizable #126384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126384
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0bf7038 with merge base d61a81a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added
module: PrivateUse1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121797
As described in the issue, currently, torch is unable to save
SpraseCOOTensor in PrivateUse1(including csr/csc/bsr/bsc). The reason is that SparseTensor does not have storage, and numpy cannot handle sparse, so it cannot be saved.I think
PrivateUse1should be moreCUDAoriented than a few special devices likeXLA, MTIA, MAIA.Please let me know if the deleted code is necessary in some special scenarios.
cc @NmomoN @mengpenghui @fwenguang @cdzhan @1274085042 @PHLens