-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import MKL via //third-party/mkl targets #126371
Conversation
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @MatzeB, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126371
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 2d2bf82 with merge base c860df5 (): FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D57360438 |
Summary: This is a step towards upgrading the MKL library and using a buckified targets rather than importing from TP2. - Add new `//third-party/mkl:mkl_xxx` targets that are currently aliases to `third-party//IntelComposerXE:mkl_xxx`. - Switch usage of `external_deps = [("IntelComposerXE", None, "mkl_xxx")]` to `deps = ["fbsource//third-party/mkl:mkl_xxx"]` Note that this only changes references to `mkl_xxx` references in `IntelComposerXE` but not references to "svml" or "ipp*". Test Plan: sandcastle Differential Revision: D57360438
This pull request was exported from Phabricator. Differential Revision: D57360438 |
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @MatzeB, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: This is a step towards upgrading the MKL library and using a buckified targets rather than importing from TP2. - Add new `//third-party/mkl:mkl_xxx` targets that are currently aliases to `third-party//IntelComposerXE:mkl_xxx`. - Switch usage of `external_deps = [("IntelComposerXE", None, "mkl_xxx")]` to `deps = ["fbsource//third-party/mkl:mkl_xxx"]` Note that this only changes references to `mkl_xxx` references in `IntelComposerXE` but not references to "svml" or "ipp*". Test Plan: sandcastle Differential Revision: D57360438 Pull Request resolved: pytorch#126371 Approved by: https://github.com/bertmaher
Summary:
This is a step towards upgrading the MKL library and using a buckified targets rather than importing from TP2.
//third-party/mkl:mkl_xxx
targets that are currently aliases tothird-party//IntelComposerXE:mkl_xxx
.external_deps = [("IntelComposerXE", None, "mkl_xxx")]
todeps = ["fbsource//third-party/mkl:mkl_xxx"]
Note that this only changes references to
mkl_xxx
references inIntelComposerXE
but not references to "svml" or "ipp*".Test Plan: sandcastle
Differential Revision: D57360438