Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Update 'person_of_interest.rst', 'CODEOWNERS' and 'merge_rules.yaml' #126364

Open
wants to merge 2 commits into
base: gh/BowenBao/315/base
Choose a base branch
from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented May 16, 2024

Stack from ghstack (oldest at bottom):

The following are all constrained under the ONNX exporter project scope.

  • personal_of_interest.rst
  • CODEOWNERS
    • Removing folks no longer working on the project.
    • Updating new owners who will now be notified with PRs related to
      the specific file paths.
  • merge_rules.yaml
    • Removing folks no longer working on the project.

🫡

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang

[ghstack-poisoned]
Copy link

pytorch-bot bot commented May 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126364

Note: Links to docs will display an error until the docs builds have been completed.

❌ 10 New Failures

As of commit d1fe3f7 with merge base 946b96f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

BowenBao added a commit that referenced this pull request May 16, 2024
….yaml'

The following are all constrained under the ONNX exporter project scope.

- `personal_of_interest.rst`
  - Moving folks no longer working on the project to emeritus.
  - Adding justinchuby, titaiwangms, shubhambhokare1 and xadupre,
    who have all made countless contributions to this project.
- `CODEOWNERS`
  - Removing folks no longer working on the project.
  - Updating new owners who will now be notified with PRs related to
    the specific file paths.
- `merge_rules.yaml`
  - Removing folks no longer working on the project.

ghstack-source-id: c21e8d770424caa55a7d704a0119936ad20320a1
Pull Request resolved: #126364
@BowenBao BowenBao added the topic: not user facing topic category label May 16, 2024
@BowenBao BowenBao marked this pull request as ready for review May 16, 2024 17:56
@BowenBao BowenBao requested review from a team, thiagocrepaldi and wschin as code owners May 16, 2024 17:56
@titaiwangms
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 17, 2024
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@titaiwangms
Copy link
Collaborator

@malfet PTAL

@titaiwangms
Copy link
Collaborator

@kit1980 PTAL

@titaiwangms titaiwangms added the onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request module: dynamo onnx-needs-import This PR is related to ONNX, but touches files outside of merge rule patterns, and hence needs import open source release notes: releng release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants