Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for Siamese Network Example #2903

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DeepC004
Copy link
Contributor

@DeepC004 DeepC004 commented Mar 31, 2023

Fixes #2878

Description: Adds unit test for Siamese Network example, updated README and minor changes

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added ci CI examples Examples labels Mar 31, 2023
Co-authored-by: vfdev <vfdev.5@gmail.com>
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 6, 2023

@DeepC004 sorry for delay and I just checked the runtime and this example adds +10 minutes of CI runtime. Let's try to reduce that

@DeepC004
Copy link
Contributor Author

DeepC004 commented Apr 7, 2023

Hi, one way to reduce the training time can be increasing the batch size. I am unaware of the memory limits of the remote host used for CI, hence one way to try is to keep increasing the train and test batch size in powers of 2. Also, training time is the bottleneck hence increasing the num_workers while dataloading will not make difference, nevertheless I will play around to see if there are any improvements in runtime.

@DeepC004 DeepC004 marked this pull request as draft April 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI examples Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of more tutorial notebooks on topics like Siamese Networks and Super Resolution techniques
2 participants