Add ETDumpGen_Done state and reset when in that state #3667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3667
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a4a5bd with merge base 47a29a1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57517927 |
swolchok
approved these changes
May 20, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2024
Summary: Currently when we call `get_etdump_data()` we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer. In order to support this, adding a `ETDumpGen_Done` state to which we move after calling `get_etdump_data()`. When this state is detected in `create_event_block` we implicitly call `reset()` and thus enabling writing to the flatbuffer again without any user intervention. Reviewed By: swolchok Differential Revision: D57517927
facebook-github-bot
force-pushed
the
export-D57517927
branch
from
690c63b
to
a527abc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57517927 |
tarun292
added a commit
that referenced
this pull request
May 20, 2024
Summary: Currently when we call `get_etdump_data()` we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer. In order to support this, adding a `ETDumpGen_Done` state to which we move after calling `get_etdump_data()`. When this state is detected in `create_event_block` we implicitly call `reset()` and thus enabling writing to the flatbuffer again without any user intervention. Reviewed By: swolchok Differential Revision: D57517927
tarun292
force-pushed
the
export-D57517927
branch
from
a527abc
to
93e2466
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57517927 |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2024
Summary: Currently when we call `get_etdump_data()` we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer. In order to support this, adding a `ETDumpGen_Done` state to which we move after calling `get_etdump_data()`. When this state is detected in `create_event_block` we implicitly call `reset()` and thus enabling writing to the flatbuffer again without any user intervention. Reviewed By: swolchok Differential Revision: D57517927
facebook-github-bot
force-pushed
the
export-D57517927
branch
from
93e2466
to
7ddfd28
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57517927 |
Summary: Currently when we call `get_etdump_data()` we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer. In order to support this, adding a `ETDumpGen_Done` state to which we move after calling `get_etdump_data()`. When this state is detected in `create_event_block` we implicitly call `reset()` and thus enabling writing to the flatbuffer again without any user intervention. Reviewed By: swolchok Differential Revision: D57517927
tarun292
force-pushed
the
export-D57517927
branch
from
7ddfd28
to
5a4a5bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57517927 |
|
This pull request has been merged in 07dcf35. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently when we call
get_etdump_data()we finalize the flatbuffer and close it. In order to add entries to etdump once again after we've closed it we need to reset the etdump buffer.In order to support this, adding a
ETDumpGen_Donestate to which we move after callingget_etdump_data(). When this state is detected increate_event_blockwe implicitly callreset()and thus enabling writing to the flatbuffer again without any user intervention.Differential Revision: D57517927