-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate getdata and putdata tests #8017
base: main
Are you sure you want to change the base?
Conversation
test_image_getdata_putdata.py seems like a mouthful. How about just test_image_data.py? |
sure |
55f68cc
to
2182da0
Compare
Sorry, I've just realised what this meant. In main, we currently have test_image_getdata.py and test_image_putdata.py, and here you've merged them together into a single file because you'd like to find a new home for a test from test_image.py / #7209, and you don't think a roundtrip test belongs in either file. I think test_image_putdata.py already has roundtrip tests, using both Pillow/Tests/test_image_putdata.py Lines 60 to 68 in c250a44
|
I'd say those should be in the combined file for the same reason. Though I suppose I shouldn't have added |
Cleaned up the tests a bit more. |
9b10658
to
ba83ec4
Compare
rebased, multiple times because I didn't check it locally and kept missing something when resolving the conflict |
This test had some duplicate checks because originally in Python 2 the numbers in those lines had a "L" suffix, which is no longer used in Python 3.
The original bug this was referring to seems to have been lost, but it looks to have been something to do with Python 2/3 compatibility and big numbers. See commit c8ce29c and python-pillow#7991.
Co-authored-by: Ondrej Baranovič <ondreko.tiba@gmail.com>
…_scale_and_offset()
b00fded
to
32c46eb
Compare
Moved all of the
getdata
andputdata
tests to the same file (becausetest_getdata_putdata
doesn't fit in either individual file), and parametrized two tests.