-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): don't require --id
when enabling a deploy key
#2859
Conversation
7cf32f9
to
00bba45
Compare
Hi @nejch Maybe there is a simpler way to do this. As an FYI. I have the idea, as a follow-up, to add a |
00bba45
to
761889f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nejch
Maybe there is a simpler way to do this.
As an FYI. I have the idea, as a follow-up, to add a
help
argument to theCustomAction
andregister_custom_action
to enable adding help text to commands if desired
I took a look and looks like the best way to do it. I can't think of another way since custom actions can be really different sometimes 🙇 Just 2 nits from my side as it's a big PR but good to go otherwise!
761889f
to
1f8a071
Compare
4434a60
to
e08545a
Compare
This makes it more obvious when reading the code what each argument is for.
This adds the `.git-blame-ignore-revs` file which allows ignoring certain commits when doing a `git blame --ignore-revs` Ignore the commit that requires keyword arguments for `register_custom_action()` https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view
In some cases we don't want to have `_id_attr` as an argument. Add ability to have it not be added as an argument.
No longer require `--id` when doing: gitlab project-key enable Now only the --project-id and --key-id are required.
e08545a
to
343bc3d
Compare
No longer require
--id
when doing:gitlab project-key enable
Now only the --project-id and --key-id are required.