Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add support for gitlab service account #2851

Merged

Conversation

SachinKSingh28
Copy link
Contributor

Adds support for creating group service account: https://docs.gitlab.com/ee/api/groups.html#service-accounts

#2812

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (7ec3189) to head (5256a9c).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   96.52%   96.51%   -0.02%     
==========================================
  Files          90       91       +1     
  Lines        5872     5907      +35     
==========================================
+ Hits         5668     5701      +33     
- Misses        204      206       +2     
Flag Coverage Δ
api_func_v4 82.39% <100.00%> (+0.15%) ⬆️
cli_func_v4 83.61% <100.00%> (+0.02%) ⬆️
unit 88.33% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
gitlab/v4/objects/__init__.py 100.00% <100.00%> (ø)
gitlab/v4/objects/groups.py 95.90% <100.00%> (+0.04%) ⬆️
gitlab/v4/objects/service_accounts.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @SachinKSingh28! Looks good. I just have a few comments 🙇

docs/gl_objects/groups.rst Outdated Show resolved Hide resolved
gitlab/v4/objects/service_accounts.py Outdated Show resolved Hide resolved
tests/functional/api/test_groups.py Outdated Show resolved Hide resolved
tests/unit/objects/test_groups.py Outdated Show resolved Hide resolved
tests/unit/objects/test_groups.py Outdated Show resolved Hide resolved
@SachinKSingh28 SachinKSingh28 force-pushed the feat/add-service-account-management branch 2 times, most recently from b1f676a to 148fb7e Compare May 9, 2024 02:48
@JohnVillalovos JohnVillalovos force-pushed the feat/add-service-account-management branch 2 times, most recently from 77ca5e2 to 53dcd8c Compare May 14, 2024 01:19
@SachinKSingh28
Copy link
Contributor Author

@nejch addressed your comments! Ready for a review again.

@SachinKSingh28 SachinKSingh28 force-pushed the feat/add-service-account-management branch from 8b92a39 to e68c9e2 Compare May 15, 2024 21:32
@JohnVillalovos JohnVillalovos force-pushed the feat/add-service-account-management branch from e68c9e2 to c628ab3 Compare May 16, 2024 23:46
@nejch
Copy link
Member

nejch commented May 17, 2024

Thanks again @SachinKSingh28, I applied a nit left over from the first round myself so we don't block this anymore. I'll squash and merge 👍

@nejch nejch enabled auto-merge (squash) May 17, 2024 10:30
@nejch nejch force-pushed the feat/add-service-account-management branch from 5256a9c to 61b4f7f Compare May 17, 2024 10:30
@nejch nejch merged commit b187dea into python-gitlab:main May 17, 2024
16 checks passed
@SachinKSingh28 SachinKSingh28 deleted the feat/add-service-account-management branch May 17, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants