-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add support for gitlab service account #2851
feat(api): add support for gitlab service account #2851
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
- Coverage 96.52% 96.51% -0.02%
==========================================
Files 90 91 +1
Lines 5872 5907 +35
==========================================
+ Hits 5668 5701 +33
- Misses 204 206 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @SachinKSingh28! Looks good. I just have a few comments 🙇
b1f676a
to
148fb7e
Compare
77ca5e2
to
53dcd8c
Compare
@nejch addressed your comments! Ready for a review again. |
8b92a39
to
e68c9e2
Compare
e68c9e2
to
c628ab3
Compare
Thanks again @SachinKSingh28, I applied a nit left over from the first round myself so we don't block this anymore. I'll squash and merge 👍 |
5256a9c
to
61b4f7f
Compare
Adds support for creating group service account: https://docs.gitlab.com/ee/api/groups.html#service-accounts
#2812