Update type-hints #2159
Draft
Update type-hints #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2159 +/- ##
==========================================
- Coverage 95.42% 95.40% -0.02%
==========================================
Files 79 79
Lines 5198 5206 +8
==========================================
+ Hits 4960 4967 +7
- Misses 238 239 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
force-pushed
the
jlvillal/find_non_dict
branch
9 times, most recently
from
bf02f9e
to
d4c2b57
Compare
Update code so that the `warn_return_any` check passes.
The methods `http_get()` and `http_post()` can also return a `list`. Update the code to handle that case. Closes: #2158
The `participants()` method returns a list of dictionaries. Update the type-hints for it.
The functions return Optional[bool]. Add tests for their behavior
JohnVillalovos
force-pushed
the
jlvillal/find_non_dict
branch
from
d4c2b57
to
00b3e26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: correct type-hints for
participants()methodThe
participants()method returns a list of dictionaries. Update thetype-hints for it.
chore: correct type-hints for
http_get/http_postderived valuesThe methods
http_get()andhttp_post()can also return alist.Update the code to handle that case.
Closes: #2158