Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update type annotations for http_* methods #2158

Open
JohnVillalovos opened this issue Jul 21, 2022 · 0 comments · May be fixed by #2159
Open

Need to update type annotations for http_* methods #2158

JohnVillalovos opened this issue Jul 21, 2022 · 0 comments · May be fixed by #2159
Assignees
@JohnVillalovos
Labels
typing

Comments

@JohnVillalovos
Copy link
Member

The type annotations for the http_* methods need to be updated.

In reality they return more than just a Dict[str, Any] but can also return a List[Any]. For example the issues.particpants() call returns a list of dictionaries.
@JohnVillalovos JohnVillalovos self-assigned this Jul 21, 2022
JohnVillalovos added a commit that referenced this issue Jul 21, 2022
@JohnVillalovos
chore: correct type-hints for http_get/http_post derived values
1f9becb 
The methods `http_get()` and `http_post()` can also return a `list`.
Update the code to handle that case.

Closes: #2158
@JohnVillalovos JohnVillalovos linked a pull request Jul 21, 2022 that will close this issue
Draft
JohnVillalovos added a commit that referenced this issue Jul 23, 2022
@JohnVillalovos
chore: correct type-hints for http_get/http_post derived values
97f8233 
The methods `http_get()` and `http_post()` can also return a `list`.
Update the code to handle that case.

Closes: #2158
JohnVillalovos added a commit that referenced this issue Jul 23, 2022
@JohnVillalovos
chore: correct type-hints for http_get/http_post derived values
688a3ea 
The methods `http_get()` and `http_post()` can also return a `list`.
Update the code to handle that case.

Closes: #2158
@nejch nejch added the typing label Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnVillalovos JohnVillalovos

Labels
typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update type-hints python-gitlab/python-gitlab
2 participants
@JohnVillalovos @nejch