Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Unregistered Mark Warning in Command Line Usage #12246

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

mberkowitz03
Copy link

<!-

  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

Closes #10514
Emit a warning when -m is used with unregistered marks

  • Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.
  • Add yourself to AUTHORS in alphabetical order.
    -->

@mberkowitz03
Copy link
Author

mberkowitz03 commented Apr 26, 2024

Sorry - some of the commits are from work on another issue that I accidentally had migrated to this branch. I'd like this PR squashed, anyway.

@mberkowitz03
Copy link
Author

I don't love adding arguments to the expression compiler, but I couldn't find a more appropriate way to do it, because of the way command line arguments are parsed. Open to suggestions!

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Max! This looks pretty good to me; we'll just need some tests to make sure we'll notice if a future PR would break it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emit a warning when using an unregistered mark via -m
2 participants