-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move fixture finalizing to pytest_fixture_teardown hook #12164
base: main
Are you sure you want to change the base?
Conversation
I was just about to submit a PR with almost identical code changes when I discovered yours :) |
90172a2
to
28169e9
Compare
that failing test does not seem to be related to the contributed code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good to me, how does this interact with pytest-asyncio?
For pytest-asyncio, everything should work without additional improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking "Request changes" as per my comment on the issue: #12163 (comment)
@ShurikMen @rplevka please let me know in the issue if you have any specific use case for pytest_fixture_teardown
instead of extending pytest_fixture_post_finalizer
solution #12163