Add failing tests for trait and maybe #125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRigal
force-pushed
the
testing_traits_and_maybes
branch
from
b0103d2
to
d2c1ca1
Compare
MRigal
force-pushed
the
testing_traits_and_maybes
branch
from
d2c1ca1
to
b8f310a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failing tests in test_maybe_trait will fail with all factoryboy versions, but has minor consequences, as there is an obvious work-around. They may rely completely inside factory-boy itself, see this PR
The test failing with test_circular with Trait as Params fails with Version 3.2 and this PR with massive consequences, as factory.Maybe does not have a
call()Method anymore. This failure is harder, as it fails at register, where the Maybe Class is passed to make_deferred_postgen