rework types, migrate parsing and add encoding #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
LGTM!
Also needs a CHANGELOG update to mention all the fixes, or at least #48?
| @@ -2,4 +2,3 @@ include LICENSE | |||
| include example.ini | |||
There was a problem hiding this comment.
Curious: is this file needed at all given we use setuptools-scm?
There was a problem hiding this comment.
probably not anymore
|
i'll squash the fixup commits then prepare for more |
RonnyPfannschmidt
force-pushed
the
rework-types
branch
from
5aa378d
to
cf722ae
Compare
nicoddemus
reviewed
Dec 7, 2022
inwaves
reviewed
Dec 7, 2022
RonnyPfannschmidt
force-pushed
the
rework-types
branch
from
cf722ae
to
10583b8
Compare
bluetech
reviewed
Dec 8, 2022
RonnyPfannschmidt
force-pushed
the
rework-types
branch
from
98e6ff3
to
0253ff1
Compare
RonnyPfannschmidt
force-pushed
the
rework-types
branch
from
dc556c2
to
c7d1d88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #44
fixes #48
addresses #5
fixes #43