Decode error in pytest.ini with chinese characters #5 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry this is not the right way to do this |
|
Hey @RobertT93, what happened. Why do you think it's incorrect? iniconfig announced that it supports comments , so it seems right to open files using utf8. |
code right now use open without encoding parameter, in this way python gets default encoding for system. "The default encoding is platform dependent (whatever locale.getpreferredencoding() returns)," In this pull request i hardcoded this as utf-8. This may lead to change of behavior. in another thread adding parameter to pytest was suggested and i think this may be the key #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to fix Decode error in pytest.ini with chinese characters #5
#5