Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs notebook links #206

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

jbousquin
Copy link

Attempt to implement doc changes for #204. First commit was the link update, concerns over the rest:

  • I wasn't able to test the build locally (or easily on my fork as build_docs.yml looks like it both builds and deploys).
  • nbsphinx appears to already build extract_urban_areas & binary_dasymetric even though they aren't in docs/notebooks? If the same would work for the others all this other nblink could be avoided.

@knaaptime
Copy link
Member

knaaptime commented Feb 16, 2024

nbsphinx appears to already build extract_urban_areas & binary_dasymetric even though they aren't in docs/notebooks? If the same would work for the others all this other nblink could be avoided.

🤣 i was just trying to figure that out myself after #205 (though im happy to close that in favor of this).

One thing about those two is they dont have file extensions in the rst, which may be something?

EDIT nope, i see you tried that. im not sure 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants