Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site docs return 404 #204

Open
JosiahParry opened this issue Feb 16, 2024 · 6 comments · May be fixed by #205
Open

Site docs return 404 #204

JosiahParry opened this issue Feb 16, 2024 · 6 comments · May be fixed by #205

Comments

@JosiahParry
Copy link
Contributor

The 3 vignettes at pysal.org/tobler presently return a 404 with nbviewer.

For example: https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

@knaaptime
Copy link
Member

hm, looks like thats cause they're still pointing at master instead of main (swap and it works fine)

im not actually sure where thats happening cause that notebook is sitting in the docs dir where it should be. Will take a look, thanks for raising

@knaaptime
Copy link
Member

@jGaboardi do you remember where those are set?

@jGaboardi
Copy link
Member

https://nbviewer.org/github/pysal/tobler/blob/master/notebooks/census_to_hexgrid.ipynb

Where is that above link coming from? Are you simply launching nbviewer manually or do we have that link embedded somewhere in the repo/docs site?

@jbousquin
Copy link

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

For the docs tutorial page, tutorial.rst is pointing to the notebooks in docs/notebooks (e.g., 01_interpolation_methods_overview.ipynb). I ran into this recently in a different project where I didn't want to maintain two copies. sphinx may not like ../ and I found nbsphinx_link worked for me if you're open to the added docs requirement.

@jGaboardi
Copy link
Member

Looks like those nbviewer links are hardcoded directly in the index.rst (lines ~13, 21, 29, so just a link update?).

Yep, this looks to be the case!

@knaaptime
Copy link
Member

Sweet, thanks @jbousquin! Nbsphinx_link looks great

@knaaptime knaaptime linked a pull request Feb 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants