Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'lowest' parameter for User Specified Binning. #168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nalad
Copy link

@Nalad Nalad commented Jan 24, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 24, 2023

Codecov Report

Merging #168 (fdaadd6) into main (3c2bb92) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #168   +/-   ##
=====================================
  Coverage   88.5%   88.5%           
=====================================
  Files          8       8           
  Lines       1070    1070           
=====================================
  Hits         947     947           
  Misses       123     123           
Impacted Files Coverage Δ
mapclassify/_classify_API.py 96.6% <100.0%> (ø)

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also expand the test here to cover this case?

@jGaboardi jGaboardi mentioned this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants