Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] remove Ids attribute #299

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] remove Ids attribute #299

wants to merge 2 commits into from

Conversation

sjsrey
Copy link
Member

@sjsrey sjsrey commented Jun 29, 2020 •
edited

This is addressing #284 and would remove the ids attribute.

Remaining to be done:

  • 3 locally failing tests in test_contiguity.py
  • testing downstream

@sjsrey sjsrey requested a review from ljwolf June 29, 2020 04:09
@sjsrey sjsrey changed the title Ids WIP: remove Ids attribute Jun 29, 2020
@sjsrey sjsrey changed the title WIP: remove Ids attribute [WIP] remove Ids attribute Jun 29, 2020
@sjsrey
Copy link
Member Author

sjsrey commented Jun 29, 2020 •
edited

The remaining tests that are failing involve the idVariable.

In exploring those tests, I think they are covering behaviour that is not longer supported when ids are removed. At the same time, we might also want to remove idVariable support as it was the combination of ids and idVariable that has caused a lot of complications.

@sjsrey sjsrey marked this pull request as draft June 30, 2020 02:40
@ljwolf ljwolf added the weights label Oct 19, 2021
@martinfleis martinfleis changed the base branch from master to main February 27, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljwolf ljwolf Awaiting requested review from ljwolf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
weights
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sjsrey @ljwolf