Details about known caveats of using multiple processes in pre-commit #9463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
Documentation 📗
Skip news 🔇
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9463 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 174 174
Lines 18907 18907
=======================================
Hits 18125 18125
Misses 782 782 |
Pierre-Sassoulas
force-pushed
the
doc-improvements
branch
from
cba7038
to
12d5b4a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Pierre-Sassoulas
force-pushed
the
doc-improvements
branch
from
12d5b4a
to
14d653e
Compare
doc/user_guide/usage/run.rst
Outdated
Comment on lines
168
to
175
| You can also do you own parallelization by launching pylint multiple time on subsets | ||
| of your files (like ``pre-commit`` with the default ``require_serial=false`` does). | ||
| Be aware though pylint should analyses all your code at once in order to best infer | ||
| the actual values that are passed in calls. If only some of the files are given pylint | ||
| might miss a particular value's type and produce inferior inference for the subset. | ||
| It can also be unexpectedly different when the file set changes because the new | ||
| slicing can change the inference. So, don't do this if correctness and determinism is | ||
| important to you. |
There was a problem hiding this comment.
I'm not sure if -j option is really better than a custom attempt at parallelization atm.
Pierre-Sassoulas
force-pushed
the
doc-improvements
branch
from
14d653e
to
1698065
Compare
jacobtylerwalls
previously approved these changes
May 19, 2024
| @@ -19,6 +37,7 @@ as follows: | |||
| entry: pylint | |||
| language: system | |||
| types: [python] | |||
| require_serial: true | |||
…tiple processes Refs microsoft/vscode-pylint#454 Also add known caveats for custom parallization. Closes pylint-dev#9341 Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Pierre-Sassoulas
force-pushed
the
doc-improvements
branch
from
b91afe1
to
2b7100b
Compare
|
I can't believe how many mistakes would be in the doc if you weren't reviewing 🥲 |
jacobtylerwalls
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9341
Closes #9465
Also fix the release doc for something that bit me during 3.1.0 release.