Warn on incomplete concrete classes that inherit from abstract classes #7955
+41
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
added
the
False Negative 🦋
sshane
changed the title
This comment has been minimized.
This comment has been minimized.
sshane
commented
Dec 22, 2022
This comment has been minimized.
This comment has been minimized.
sshane
force-pushed
the
W0223-widening
branch
from
0652845
to
855c354
Compare
This comment has been minimized.
This comment has been minimized.
|
Updated the test refs, but I'm not sure they're right. I'm getting lots of diffs for a lot of tests. Running pylint built from main on Windows 11 ( It appears I'm getting the correct output with Ubuntu 20.04, but |
for more information, see https://pre-commit.ci
|
Should be good now, let me know if there's any issues @DanielNoord! I had to add a print into the tester to get the results :/ |
|
🤖 Effect of this PR on checked open source code: 🤖 Effect on pandas:
Effect on psycopg:
Effect on sentry:
This comment was generated for commit afd9500 |
DanielNoord
requested changes
Jan 2, 2023
Comment on lines
+1180
to
+1181
| and inferred_base.root().name in ABC_MODULES | ||
| and inferred_base.name == "ABC" |
There was a problem hiding this comment.
Suggested change
| and inferred_base.root().name in ABC_MODULES | |
| and inferred_base.name == "ABC" | |
| and inferred_base.root().name in ABC_MODULES | |
| and inferred_base.name == "ABC" |
I think this works fine. Note that you could also call .qname() for a similar result.
There was a problem hiding this comment.
Yes, but do we not care about checking all the modules in ABC_MODULES to preserve behavior? You suggested no change btw
sshane
commented
Jan 2, 2023
|
@DanielNoord is there anything else needing to be done? |
The CI fails so we would first need to fix that before this can be merged. |
|
For whatever reason, both Python 3.8 and 3.10 do not work to update the abstract method file. I'm running self = <pylint.testutils.functional.lint_module_output_update.LintModuleOutputUpdate object at 0x7fa1e3c6d690>
def runTest(self) -> None:
> self._runTest()
E AssertionError: Wrong results for file "abstract_method":
E
E Unexpected in testdata:
E 47: abstract-method
../pylint/testutils/lint_module_test.py:145: AssertionError
=========================================================================================================================================== short test summary info ===========================================================================================================================================
FAILED test_functional.py::test_functional[abstract_method] - AssertionError: Wrong results for file "abstract_method":
============================================================================================================================ 1 failed, 779 passed, 25 skipped in 62.76s (0:01:02) ============================================================================================================================= |
|
Could it be that the test simply fails? If haven't checked that myself locally |
|
Do you have any docs for what the comments do? For example, I'm not sure if Are the functional tests a sort of blend of replay with the file outputs and unit tests? |
This (attempts to) describe the functional test framework. Basically it tries to lint the file and sees where we expect messages to be raised and compares that against the actual output of the linting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7950
TODO: