-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Use lief library and stop depending on binutils #5996
base: develop
Are you sure you want to change the base?
Conversation
@@ -68,7 +68,7 @@ jobs: | |||
pip install --progress-bar=off -U -r tests/requirements-tools.txt -r tests/requirements-libraries.txt | |||
# Compile bootloader | |||
cd bootloader | |||
python waf all | |||
python waf all CFLAGS="-fcf-protection=none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does control-flow transfer instrumentation interfere with executable modification made via lief
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks quite nice... |
My only cause for squeamishness is Alpine. I have now managed to build a wheel for it after running:
first and waiting a couple of hours. A really organized company could feasibly build the wheel once then host it on a private PyPI instance with the restrictions on non-glibc wheels removed. This will hopefully go away once PEP656 happens. It also adds a runtime dependency on libstdc++ which isn't the end of the world but it's still a breaking change. |
I think this is the reason why it takes so long to build lief (defaults to |
No description provided.