WIP: Using cgraph/gvc lib interface for wheel building #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will break local builds, but is an attempt to figure out how to get all of the necessary layout lib dependencies registered so that they are picked up by auditwheel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP progress PR for testing out the workflow to provide binary wheels. The two major sets of changes are:
setup.py) to get the build/packaging working in a multilinux environment (to start - wheels for other platforms later!)Step 1 is straightforward and merely switches to the lib interface which was added in #244 (thanks @dschult for doing the real work :). Changes along these lines will be incorporated into the library in order to make the binary wheels work.
Step 2 is all experimentation to get the build working and will likely break local builds so would/should not be incorporated as is. Once we figure out a working recipe for the wheels we can figure out how best to manage local installs (e.g. by developers) vs. wheel-generation (e.g. done in CI).