Raise exception when using diff with a non-existent dimension
#8962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
max-sixty
reviewed
Apr 22, 2024
| @@ -3861,6 +3861,12 @@ def test_dataarray_diff_n1(self) -> None: | |||
| expected = DataArray(np.diff(da.values, axis=1), dims=["x", "y"]) | |||
| assert_equal(expected, actual) | |||
|
|
|||
| def test_dataarray_diff_dim_nonexist(self) -> None: | |||
| # uncomment this code for test corresponding to pushed changes | |||
| # with pytest.raises(KeyError, match=r"dim provided not present"): | |||
There was a problem hiding this comment.
This can use pytest.warns
| @@ -7726,6 +7726,7 @@ def diff( | |||
| n: int = 1, | |||
| *, | |||
| label: Literal["upper", "lower"] = "upper", | |||
| dims_found=False, | |||
There was a problem hiding this comment.
Do we need this? I think it can be defined inside the function
Comment on lines
+39
to
+41
| - Fix for :py:meth:`DataSet.diff` and consequently :py:meth:`DataArray.diff` to | ||
| raise a KeyError when `diff` is parameterized with a dimension that does not | ||
| exist in callee's DataSet/DataArray. (:issue:`7748`) |
There was a problem hiding this comment.
This is fine, though we can also simplify the language a bit — cut words like consequently / parameterized with!
dcherian
changed the title
diff with a non-existent dimension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rst