feat: support running Puppeteer in extensions #12459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
commented
May 17, 2024
oliverdunk
suggested changes
May 17, 2024
OrKoN
force-pushed
the
orkon/extensions
branch
3 times, most recently
from
41e1082
to
417d691
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for running Puppeteer inside a Chrome extension using chrome.debugger for communication with CDP.
It also marks the ExtensionTransport public.
It also changes how Puppeteer stringifies JS functions: if CSP prevents the use of
new Function()we assume the function is serializable.