Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten ThreadPool trimmer and reaper thread names #3383

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshuay03
Copy link
Contributor

@joshuay03 joshuay03 commented May 19, 2024

Description

Similar to #2733

Here's an example htop output for 2 workers and 2 threads:
Screenshot 2024-05-19 at 10 55 58 AM

Notice the two puma srv thread names which are really puma srv threadpool trimmer and puma srv threadpool reaper. This PR simply shortens the names to keep them under 15 chars while keeping the naming consistent with the main thread pool threads (e.g. puma srv tp 001).

Note: Puma::Server#run (which initializes a Threadpool) is only every initialised with srv and ctl so this new length works in both cases.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature waiting-for-review Waiting on review from anyone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants