Update DSL hook processing logic to be consistent #3376
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
commented
May 2, 2024
| @@ -731,6 +729,8 @@ def on_booted(&block) | |||
| # @version 5.0.0 | |||
| # | |||
| def on_refork(key = nil, &block) | |||
| warn_if_in_single_mode('on_refork') | |||
There was a problem hiding this comment.
I think this makes sense here? This seemed to be the only cluster mode related hook that was missing the warning.
joshuay03
commented
May 2, 2024
Comment on lines
-1207
to
+1205
| "so your `#{hook_name}` block did not run" | ||
| "so your `#{hook_name}` block will not run." |
There was a problem hiding this comment.
This warning is displayed during configuration, so it makes more sense to tell the user that it will not run, as the hooks haven't actually been processed yet.
joshuay03
force-pushed
the
consistent-dsl-hook-processing
branch
from
6692b90
to
7c6c31e
Compare
joshuay03
commented
May 2, 2024
There was a problem hiding this comment.
Added coverage for hooks missing in this suite.
7 tasks
|
Note to self, related PR: #3380. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed some inconsistencies with how the DSL processes hooks while working on #3375, this was also opened as a split up prerequisite for #3377.
Ensures all hook DSL methods utilise
#process_hooks+ some minor changes (see comments).Your checklist for this pull request
[ci skip]to the title of the PR.#issue" to the PR description or my commit messages.