-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix update phased restart symlink folder #3295
base: master
Are you sure you want to change the base?
fix update phased restart symlink folder #3295
Conversation
Any idea how we could test this? |
6fad6b8
to
d32e670
Compare
If you are asking about testing the branch, here how I done it Temporary changes
for 2nd testing update If you are asking about writing test cases for this |
@@ -142,4 +145,10 @@ def with_unbundled_env | |||
Bundler.with_unbundled_env { yield } | |||
end | |||
end | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added testcases in TestWorkerGemIndependence
. not sure if it should be in separate or new class.
also used grep here as I did not find any alternative to get the title of Process running. we are using setproctitle
to set the title but there is no equivalent to this for get.
@dentarg can you check this once? |
I'll check whenever, no stress in open source |
Is there anything remaining in this from my side? |
6629294
to
558b048
Compare
Description
Fixes #3290
During phased restart updated the tag name with folder base name if tag is not set in puma config.
Your checklist for this pull request
[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.