[MNT][FIX] Update GitHub actions for MacOS #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
==========================================
- Coverage 93.83% 91.38% -2.45%
==========================================
Files 90 128 +38
Lines 7782 11481 +3699
==========================================
+ Hits 7302 10492 +3190
- Misses 480 989 +509
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tallyhawley
changed the title
jgranley
approved these changes
May 22, 2024
jgranley
added a commit
that referenced
this pull request
May 22, 2024
* [ENH] Update wheels (#610) * update wheels * test with cibuildwheel 2.16.5 * [MNT][FIX] Update GitHub actions for MacOS (#619) * update github actions python setup * exclude 3.8 and 3.9 from macos runners? * exclude 3.8 and 3.9 from macos runners? * add ffmpeg setup step for macos? * add macos-13 * add ffmpeg setup back, edit videostimulus tests to be more lenient * add error message for percept save max test * widen allowance for percept save --------- Co-authored-by: isaac hoffman <ihoffman@ucsb.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the GitHub actions workflows so that Python is actually installed and setup properly on MacOS runners.
Excludes 3.8 and 3.9 for latest mac since there is no runner, and adds in macos-13 to test these versions. Also installs ffmpeg for latest mac.
Type of Change
Please delete options that are not relevant.