Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Implemented TorchAxonMapSpatial #618

Open
wants to merge 11 commits into
base: torch
Choose a base branch
from

Conversation

whuang602
Copy link

@whuang602 whuang602 commented May 7, 2024

Description

Implemented TorchAxonMapSpatial class with constructor and forward function. Forward function may need additional post processing steps.

AxonMapSpatial now allows for self.engine to be torch, on top of jax, cython, and serial.

Pytest is failing on Github, this will be addressed and fixed.

Closes #614

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

For detailed information on these and other aspects, see the contribution guidelines: https://pulse2percept.readthedocs.io/en/latest/developers/contributing.html

jgranley and others added 9 commits February 29, 2024 14:30
* update wheels

* test with cibuildwheel 2.16.5
* update github actions python setup

* exclude 3.8 and 3.9 from macos runners?

* exclude 3.8 and 3.9 from macos runners?

* add ffmpeg setup step for macos?

* add macos-13

* add ffmpeg setup back, edit videostimulus tests to be more lenient

* add error message for percept save max test

* widen allowance for percept save
@tallyhawley tallyhawley changed the base branch from master to torch June 10, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add torch engine for AxonMapModel
3 participants