update biphasics model #617
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgranley
reviewed
May 13, 2024
|
|
||
| # bright | ||
| F_bright = a2 * scaled_amps + a3 * freq | ||
| if self.amp_cutoff: |
jgranley
reviewed
May 13, 2024
| setattr(self, key, val) | ||
| self.is_built = True | ||
|
|
||
| def __getattr__(self, attr): |
There was a problem hiding this comment.
A lot of these are not needed her, since theyre in BiphasicAxonMapModel
jgranley
reviewed
May 13, 2024
| # for simulation based on the current set of parameters. | ||
| print("Model built with current parameters.") | ||
|
|
||
| def _predict_spatial(self, earray, stim): |
There was a problem hiding this comment.
Any logic needed here can be moved to biphasicaxonmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue it closes below. Include relevant motivation and context.
This is a test PR to check the implementation of pytorch version of granley2021 biphasics map model. Originally it is a jax model. The existing code is subject to change after running the tests.
Closes #(issue)
Type of Change
Please delete options that are not relevant.
Checklist
For detailed information on these and other aspects, see the contribution guidelines: https://pulse2percept.readthedocs.io/en/latest/developers/contributing.html