Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH][REF] Torch Scoreboard #612

Draft
wants to merge 5 commits into
base: torch
Choose a base branch
from

Conversation

tallyhawley
Copy link
Member

@tallyhawley tallyhawley commented Mar 8, 2024

Description

Adds a PyTorch backend/engine for the cortex ScoreboardModel. This backend can be selected by passing the argument engine='torch' during model initialization.

Closes #611

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 37.83784% with 23 lines in your changes are missing coverage. Please review.

Please upload report for BASE (torch@180b83b). Learn more about missing BASE report.

Current head 0bead62 differs from pull request most recent head b472344

Please upload reports for the commit b472344 to get more accurate results.

Files Patch % Lines
pulse2percept/models/cortex/base.py 37.83% 23 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             torch     #612   +/-   ##
========================================
  Coverage         ?   92.01%           
========================================
  Files            ?      128           
  Lines            ?    11515           
  Branches         ?        0           
========================================
  Hits             ?    10596           
  Misses           ?      919           
  Partials         ?        0           
Flag Coverage Δ
unittests 92.01% <37.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant