[ENH] Add methods to initialize an EnsembleImplant from a list of coordinates #601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds two methods to initialize an
EnsembleImplant
from a set of coordinates. This should generally match the format ofNeuralink.from_neuropythy()
.EnsembleImplant.from_coords()
allows the user to pass an implant type (must subclassProsthesisSystem
) & a set of locations on the cortex/retina (in µm), or an xrange/yrange/xystep in µm. We then automatically create a set of implants of the given type at the desired locations.EnsembleImplant.from_cortical_map()
takes the same parameters asfrom_coords()
in addition to avfmap
(must be aCorticalMap
instance and implementfrom_dva()
) andregion
(defaults to v1). Locations/coordinates are passed to this function in dva, and internally converted to µm (in the given region).Possible expansion:
from_retinal_map()
. Not implemented currently due to lack of use-cases as retinal implants are generally stand-alone. Would take aneye
parameter instead ofregion
?Type of Change
Please delete options that are not relevant.
Checklist