[REF] Rename retinotopy to vfmap #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add check for empty stimulus in stim setter for implants * add check for empty np.ndarray
…cept#523) * fix implant annotation * used zorder
…l areas (pulse2percept#509) * grid interface changes * changed valueerror to runtime error in percept save test * Fix unique time point bug * temp commit to store grid stuff * update requirements * update base.py for new grid class * Grid class now supports multiple layers * refactor layer to be region * Add region_mappings, RetinalMap * Fixed overwriting static attributes * Base class for cortical models * [MNT] Update requirements.txt (pulse2percept#507) * Add tests, made inv transforms optional to overwrite * update with named tuple coordinate grids, and ret_to_dva etc " * refactor everything to ret_to_dva * Update static ret2dva references * removed backwards compatibility for ret2dva * update doc
…ulse2percept#518) * [MNT] Update requirements.txt (pulse2percept#507) * [DOC] Fix gallery thumbnail images (pulse2percept#510) * add topography module * fix imports * refactor tests for topography module * doc * add epmty submodules for implants.cortex and models.cortex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, visual field mappings are referred to as
retinotopy, but this specifically refers to the mapping from the retinal surface to the visual field. Now that we are adding cortical models, it doesn't make sense to continue using the nameretinotopy, so we are using the namevfmapinstead to denote any visual field mapping (whether it is from the retina to the visual field or from the cortex to the visual field).Closes #539
Type of Change