[FIX] Replace DataFrame.append with pd.concat #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgranley
added a commit
that referenced
this pull request
Apr 7, 2023
* [MNT] Update requirements.txt (#507) * [DOC] Fix gallery thumbnail images (#510) * [FIX] Add check for empty stimulus (#522) * add check for empty stimulus in stim setter for implants * add check for empty np.ndarray * [FIX] Fix electrode numbering annotation in implant.plot() (#523) * fix implant annotation * used zorder * [MNT][FIX] Remove outdated ubuntu workflows, add Jax version requirement (#529) * Remove 18.04, add 20.04 * Add python version to display name * remove python version * add jax version * Fix jax version * test for wheels: remove jax version * Add jax version back * test for wheels: remove jax version * Add jax version back * test for wheels * also skip win32 for python3.7 * [FIX] Use pandas concat instead of append (#540) --------- Co-authored-by: isaac hoffman <trsileneh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pandas.DataFrame.appendno longer exists in version 2.0, which causes our tests to fail. I changed it to use the recommendedpd.concatinstead.https://pandas.pydata.org/pandas-docs/version/1.5/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append
Type of Change
Checklist