Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Ensemble implant #537

Merged
merged 5 commits into from
Apr 10, 2023

Conversation

tallyhawley
Copy link
Member

@tallyhawley tallyhawley commented Mar 22, 2023

Description

Adds the EnsembleImplant which extends ProsthesisSystem. This class is meant for simulating multiple implants meant to be used in tandem, such as CORTIVIS, but can be used with any implant type. It takes a list or dict of ProsthesisSystem objects and combines their electrode arrays.

If the input is a list, the new electrodes are named in the form idx-electrode_name where idx is the index of the implant in the list.
If the input is a dict, the new electrodes are named in the form key-electrode_name where key is the key of the implant in the dict.

Closes #527

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (cortex@985d539). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             cortex     #537   +/-   ##
=========================================
  Coverage          ?   93.17%           
=========================================
  Files             ?      117           
  Lines             ?    10034           
  Branches          ?        0           
=========================================
  Hits              ?     9349           
  Misses            ?      685           
  Partials          ?        0           
Flag Coverage Δ
unittests 93.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tallyhawley tallyhawley linked an issue Mar 24, 2023 that may be closed by this pull request
@jgranley jgranley merged commit d2f0346 into pulse2percept:cortex Apr 10, 2023
16 checks passed
@tallyhawley tallyhawley deleted the ensemble-implant branch December 21, 2023 23:22
@jgranley jgranley mentioned this pull request Jan 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Add Ensemble Implant
3 participants