[ENH] Update grid.plot to take multiple transforms #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add check for empty stimulus in stim setter for implants * add check for empty np.ndarray
…cept#523) * fix implant annotation * used zorder
…l areas (pulse2percept#509) * grid interface changes * changed valueerror to runtime error in percept save test * Fix unique time point bug * temp commit to store grid stuff * update requirements * update base.py for new grid class * Grid class now supports multiple layers * refactor layer to be region * Add region_mappings, RetinalMap * Fixed overwriting static attributes * Base class for cortical models * [MNT] Update requirements.txt (pulse2percept#507) * Add tests, made inv transforms optional to overwrite * update with named tuple coordinate grids, and ret_to_dva etc " * refactor everything to ret_to_dva * Update static ret2dva references * removed backwards compatibility for ret2dva * update doc
…ulse2percept#518) * [MNT] Update requirements.txt (pulse2percept#507) * [DOC] Fix gallery thumbnail images (pulse2percept#510) * add topography module * fix imports * refactor tests for topography module * doc * add epmty submodules for implants.cortex and models.cortex
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## cortex #534 +/- ##
=========================================
Coverage ? 93.14%
=========================================
Files ? 115
Lines ? 9969
Branches ? 0
=========================================
Hits ? 9286
Misses ? 683
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jgranley
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Note of changes we talked about 3/14:
- The default color of gray shouldn't change for unbuilt retinotopies, or for retinal models. I'm thinking it might just be easier to have a custom dict mapping regions to colors (i.e. 'ret' -> gray, 'v1' -> red, etc) and just grab a random color from one of the sequential colormaps if the region is unknown.
- Replace
__name__with transform
…_dva=True, make discontinuity check cleaner
jgranley
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When plotting cortical models, we often want to plot multiple regions (v1, v2, and v3), but this was not possible with the existing grid.plot function
use_dvaflag that defaults toFalse, but when set toTrue, will not apply any transforms to preserve the ability to plot in dva coordinates (rather than retinal/cortical coordinates)Notebook
It's hard to write unit tests for plotting, so here is a notebook showing that plots look correct.
CortexPlotTester.pdf
Before / after notebooks for some other plots
Before
After
Closes #512
Type of Change